From 7e1e001fa7d9d9df300ced3fb83df5f12ebb722b Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Wed, 17 Feb 2016 14:58:33 +0000 Subject: [PATCH] xenpaging: do not leak if --pagefile given twice By freeing filename (which is either NULL or the previous iteration of this argument). This implements a semantic where the last --pagefile given on the command line takes precedence. This is the same semantic as the other options have. CID: 1198792 Reviewed-by: Konrad Rzeszutek Wilk Signed-off-by: Ian Campbell --- tools/xenpaging/xenpaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 0377507e11..6157d3a4b6 100644 --- a/tools/xenpaging/xenpaging.c +++ b/tools/xenpaging/xenpaging.c @@ -232,6 +232,7 @@ static int xenpaging_getopts(struct xenpaging *paging, int argc, char *argv[]) paging->vm_event.domain_id = atoi(optarg); break; case 'f': + free(filename); filename = strdup(optarg); break; case 'm': -- 2.30.2